On 21. 11. 23, 16:28, Ilpo Järvinen wrote:
On Tue, 21 Nov 2023, Jiri Slaby (SUSE) wrote:
'str_cr' contains a single character: \n. There is no need to declare it
Aren't \r and \n different characters?
Definitely, this is a thinko -- I didn't remember properly what it
contains when writing the log. Fixed.
- static char str_cr[1] = "\r";
+ static const char str_cr = '\r';
Thanks for making these cleanups.
I've reviewed all the patches in this series, so if I didn't comment a
patch or when you address my remarks, feel free to add:
thanks,
--
js
suse labs
