On Fri, Feb 12, 2021 at 6:11 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > On Fri, Feb 12, 2021 at 5:01 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote: > > > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko > > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: ... > > > > + if (ret) > > > > + return ret; > > > > > > else if (!val) > > > ret = 1; > > > > But then it become a bug again :-) > > I'm not sure why? The checks below will still happen and they may > cause an error to be returned. Oh, I misinterpreted ret = as plain return. Right. Seems okay. -- With Best Regards, Andy Shevchenko