On Fri, Feb 12, 2021 at 5:01 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote: > > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > Refactor acpi_data_prop_read_single() for less LOCs and better maintenance. > > Thanks for review, my answers below. > > ... > > > > + if (ret) > > > + return ret; > > > > else if (!val) > > ret = 1; > > But then it become a bug again :-) I'm not sure why? The checks below will still happen and they may cause an error to be returned. > ... > > > And this is just not looking good to me, sorry. > > Yeah, I think this patch is not needed right now. At least it seems no gain > from it. OK
