On Mon, Feb 08, 2021 at 12:01:57PM -0800, Randy Dunlap wrote: > Hi, > Just a couple of nits below: > > On 2/8/21 7:12 AM, Calvin Johnson wrote: > > Introduce ACPI mechanism to get PHYs registered on a MDIO bus and > > provide them to be connected to MAC. > > > > Describe properties "phy-handle" and "phy-mode". > > > > Signed-off-by: Calvin Johnson <calvin.johnson@xxxxxxxxxxx> > > --- > > > Documentation/firmware-guide/acpi/dsd/phy.rst | 133 ++++++++++++++++++ > > 1 file changed, 133 insertions(+) > > create mode 100644 Documentation/firmware-guide/acpi/dsd/phy.rst > > > > diff --git a/Documentation/firmware-guide/acpi/dsd/phy.rst b/Documentation/firmware-guide/acpi/dsd/phy.rst > > new file mode 100644 > > index 000000000000..e1e99cae5eb2 > > --- /dev/null > > +++ b/Documentation/firmware-guide/acpi/dsd/phy.rst > > @@ -0,0 +1,133 @@ > > +.. SPDX-License-Identifier: GPL-2.0 > > + > > +========================= > > +MDIO bus and PHYs in ACPI > > +========================= > > + > > +The PHYs on an MDIO bus [1] are probed and registered using > > +fwnode_mdiobus_register_phy(). > > + > > +Later, for connecting these PHYs to MAC, the PHYs registered on the > > to a MAC, Each PHY is connected to a MAC. So I'll change it to "PHYs to their respective MACs". > > > +MDIO bus have to be referenced. > > + > > +This document introduces two _DSD properties that are to be used > > +for connecting PHYs on the MDIO bus [3] to the MAC layer. > > + > > +These properties are defined in accordance with the "Device > > +Properties UUID For _DSD" [2] document and the > > +daffd814-6eba-4d8c-8a91-bc9bbf4aa301 UUID must be used in the Device > > +Data Descriptors containing them. > > + > > +phy-handle > > +---------- > > ... > > > + > > +Later, during the MAC driver initialization, the registered PHY devices > > +have to be retrieved from the MDIO bus. For this, the MAC driver need > > needs > > > +references to the previously registered PHYs which are provided > > +as device object references (e.g. \_SB.MDI0.PHY1). > > > thanks. > -- > ~Randy >
