On Tue, 2021-02-02 at 19:59 +0100, Rafael J. Wysocki wrote: > On Fri, Jan 22, 2021 at 9:47 PM Giovanni Gherdovich <ggherdovich@xxxxxxx> wrote: > > > > [cut] > > > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c > > index 1e4fbb002a31..2378bc1bf2c4 100644 > > --- a/drivers/cpufreq/acpi-cpufreq.c > > +++ b/drivers/cpufreq/acpi-cpufreq.c > > @@ -27,6 +27,10 @@ > > > > #include <acpi/processor.h> > > > > +#ifdef CONFIG_ACPI_CPPC_LIB > > Why is the #ifdef needed here? > Right, it isn't needed. The guard is necessary only later when the function cppc_get_perf_caps() is used. I'll send a v3 with this correction. Giovanni > > +#include <acpi/cppc_acpi.h> > > +#endif > > + > > #include <asm/msr.h> > > #include <asm/processor.h> > > #include <asm/cpufeature.h>