> -----Original Message----- > From: Sami Mujawar [mailto:Sami.Mujawar@xxxxxxx] > Sent: 09 November 2020 12:30 > To: david.e.box@xxxxxxxxxxxxxxx; Shameerali Kolothum Thodi > <shameerali.kolothum.thodi@xxxxxxxxxx>; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; > iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; devel@xxxxxxxxxx > Cc: Linuxarm <linuxarm@xxxxxxxxxx>; Lorenzo Pieralisi > <Lorenzo.Pieralisi@xxxxxxx>; joro@xxxxxxxxxx; Robin Murphy > <Robin.Murphy@xxxxxxx>; wanghuiqiang <wanghuiqiang@xxxxxxxxxx>; > Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>; nd <nd@xxxxxxx> > Subject: RE: [Devel] Re: [RFC PATCH 2/4] ACPI/IORT: Add support for RMR node > parsing > > Hi, > > -----Original Message----- > From: David E. Box <david.e.box@xxxxxxxxxxxxxxx> > Sent: 28 October 2020 06:44 PM > To: Shameer Kolothum <shameerali.kolothum.thodi@xxxxxxxxxx>; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; > iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; devel@xxxxxxxxxx > Cc: linuxarm@xxxxxxxxxx; Lorenzo Pieralisi <Lorenzo.Pieralisi@xxxxxxx>; > joro@xxxxxxxxxx; Robin Murphy <Robin.Murphy@xxxxxxx>; > wanghuiqiang@xxxxxxxxxx; jonathan.cameron@xxxxxxxxxx > Subject: [Devel] Re: [RFC PATCH 2/4] ACPI/IORT: Add support for RMR node > parsing > > Hi, > > On Tue, 2020-10-27 at 11:26 +0000, Shameer Kolothum wrote: > > ... > > > @@ -1647,6 +1667,100 @@ static void __init iort_enable_acs(struct > > acpi_iort_node *iort_node) > > #else > > static inline void iort_enable_acs(struct acpi_iort_node *iort_node) > > { } > > #endif > > +static int iort_rmr_desc_valid(struct acpi_iort_rmr_desc *desc) > > +{ > > + struct iort_rmr_entry *e; > > + u64 end, start = desc->base_address, length = desc->length; > > + > > + if ((!IS_ALIGNED(start, SZ_64K)) || (length % SZ_64K != 0)) > > You could just do: > > if ((!IS_ALIGNED(start, SZ_64K)) || (length % SZ_64K)) > > [SAMI] In my opinion, the following may be better: > if (!IS_ALIGNED(start, SZ_64K) || !IS_ALIGNED(length, SZ_64K)) > [/SAMI] Thanks for your suggestions. I don't have a strong opinion on either of those, but will change it with the latter one for now. Thanks, Shameer > Regards, > > Sami Mujawar > > David > _______________________________________________ > Devel mailing list -- devel@xxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxx > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
