Hi Rafael,
On 2020/9/18 21:34, Rafael J. Wysocki wrote:
On Fri, Sep 18, 2020 at 3:55 AM Hanjun Guo <guohanjun@xxxxxxxxxx> wrote:
Hi Rafael,
On 2020/9/17 23:08, Rafael J. Wysocki wrote:
Hi Hanjun,
On Thu, Sep 17, 2020 at 10:34 AM Hanjun Guo <guohanjun@xxxxxxxxxx> wrote:
For now, ACPI driver debug functionality is mixed of pr_* functions and
ACPI_DEBUG_PRINT() which is provided ACPICA core directly, ACPICA debug
functions are not friendly for users and also make ACPICA core deeply
coupled with ACPI drivers.
With the evolution of the ACPI driver code, lots of the ACPICA debug
functions used in ACPI drivers were removed away, this makes the ACPICA
debug in ACPI driver to be fragile, for example, some of the COMPONENT
such as ACPI_CONTAINER_COMPONENT and ACPI_MEMORY_DEVICE_COMPONENT are not
used anymore, they leaved as dead code.
From another aspert, removing the ACPICA debug functions didn't raise
concerns in the past, so I believe the ACPICA debug in ACPI driver can be
removed and replace with equivalent pr_* debug functions, then decouple
ACPICA debug functionality from ACPI driver.
This is a worthy goal, but the patch series appears to be a mixed bag
of changes some of which are not directly related to this goal.
Sorry for that, I sent this patch set in a hurry, I will update
as you suggested.
Hanjun Guo (25):
ACPI: cmos_rtc: Remove the ACPI_MODULE_NAME()
This, for example, should be a separate cleanup patch.
ACPI_MODULE_NAME() and _COMPONENT are both used for ACPICA
debug functionality, so I will put them in the decouple
patch set.
So if the ACPICA debug functionality is not used in the given C file,
you can drop these macros from there right away without any side
effects.
Why don't you do that in a separate series of patches then?
Good point, so I will split this patch set into four parts:
- The bugfix patch goes in separate from the rest of the series,
already sent out.
- Cleanup patches which is not related to ACPICA debug,
- ACPI: debug: Remove the not used function
- ACPI: memhotplug: Remove the state for memory device
- ACPI: processor: Remove the duplicated ACPI_PROCESSOR_CLASS macro
- ACPI: SBS: Simplify the driver init code
- ACPI: SBS: Simplify the code using module_acpi_driver()
- ACPI: tiny-power-button: Simplify the code using module_acpi_driver()
- A patch set removing all the leftover ACPICA debug functionality
which is not used in the C file, no functional change.
- A patch set for actual ABI change (RFC).
Do it make sense to you?
Thanks
Hanjun
