Hi Hanjun, On Thu, Sep 17, 2020 at 10:34 AM Hanjun Guo <guohanjun@xxxxxxxxxx> wrote: > > For now, ACPI driver debug functionality is mixed of pr_* functions and > ACPI_DEBUG_PRINT() which is provided ACPICA core directly, ACPICA debug > functions are not friendly for users and also make ACPICA core deeply > coupled with ACPI drivers. > > With the evolution of the ACPI driver code, lots of the ACPICA debug > functions used in ACPI drivers were removed away, this makes the ACPICA > debug in ACPI driver to be fragile, for example, some of the COMPONENT > such as ACPI_CONTAINER_COMPONENT and ACPI_MEMORY_DEVICE_COMPONENT are not > used anymore, they leaved as dead code. > > From another aspert, removing the ACPICA debug functions didn't raise > concerns in the past, so I believe the ACPICA debug in ACPI driver can be > removed and replace with equivalent pr_* debug functions, then decouple > ACPICA debug functionality from ACPI driver. This is a worthy goal, but the patch series appears to be a mixed bag of changes some of which are not directly related to this goal. > In order to decouple ACPICA debug functionality from ACPI driver, I do it > in two steps: > - Remove the dead ACPICA functionality code, and remove the not used > COMPONENT; > - Remove all the ACPICA debug code from ACPI drivers. > > This patch set is the first step to decouple ACPICA debug functionality > from ACPI driver, just remove the dead ACPICA functionality code and > some cleanups for ACPI drivers, should no functional change if you don't > apply the last two patches. > > Patch 1/25 ~ patch 23/25 are removing the dead code and cleanups; > Patch 24/25 ~ patch 25/25 are the actual ABI change. > > If the ABI change is making sense, I will go further to remove the > ACPICA debug functionality from ACPI driver, just keep it inside > the ACPICA core. > > Hanjun Guo (25): > ACPI: cmos_rtc: Remove the ACPI_MODULE_NAME() This, for example, should be a separate cleanup patch. > ACPI: configfs: Decouple with ACPICA > ACPI: configfs: Add the missing config_item_put() This appears to be a fix that should go in separate from the rest of the series. > ACPI: debug: Remove the not used function Another separate cleanup. > ACPI: LPSS: Remove the ACPI_MODULE_NAME() Yet another one. So can you please split up the patch set into several smaller and more manageable ones? Thanks!
