On Thu, Jun 25, 2020 at 10:29:15PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 25, 2020 at 2:06 PM kernel test robot <lkp@xxxxxxxxx> wrote:
>
> > 50 } else if (is_acpi_node(dev->parent->fwnode)) {
>
> Hmm... Is it a device or data node?
Device node.
>
> > 51 device_for_each_child_node(dev->parent, dpmac) {
> > > 52 status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(dpmac),
> > 53 "_ADR", NULL, &adr);
> > 54 if (ACPI_FAILURE(status)) {
> > 55 dev_info(dev, "_ADR returned status 0x%x\n", status);
> > 56 continue;
> > 57 } else {
> > 58 id = (u32)adr;
> > 59 if (id == dpmac_id)
> > 60 return dpmac;
> > 61 }
> > 62 }
>
> Can't you use
>
> adev = acpi_find_child_device(ACPI_COMPANION(dev->parent), dpmac_id, false);
> if (adev)
> return ...
Thanks. It looks better.
>
> ?
>
> > 63 }
>
>
> --
> With Best Regards,
> Andy Shevchenko
