Hi Calvin, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Calvin-Johnson/net-dpaa2-mac-Add-ACPI-support-for-DPAA2-MAC-driver/20200625-123653 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 147373d968f1c1b5d6bb71e4e8b7495eeb9cdcae config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c: In function 'dpaa2_mac_get_node': >> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:52:13: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration] 52 | status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(dpmac), | ^~~~~~~~~~~~~~~~~~~~~ | acpi_evaluate_object cc1: some warnings being treated as errors vim +52 drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c 26 27 /* Caller must call of_node_put on the returned value */ 28 static struct fwnode_handle *dpaa2_mac_get_node(struct device *dev, 29 u16 dpmac_id) 30 { 31 struct fwnode_handle *dpmacs, *dpmac = NULL; 32 unsigned long long adr; 33 acpi_status status; 34 int err; 35 u32 id; 36 37 if (is_of_node(dev->parent->fwnode)) { 38 dpmacs = device_get_named_child_node(dev->parent, "dpmacs"); 39 if (!dpmacs) 40 return NULL; 41 42 while ((dpmac = fwnode_get_next_child_node(dpmacs, dpmac))) { 43 err = fwnode_property_read_u32(dpmac, "reg", &id); 44 if (err) 45 continue; 46 if (id == dpmac_id) 47 return dpmac; 48 } 49 50 } else if (is_acpi_node(dev->parent->fwnode)) { 51 device_for_each_child_node(dev->parent, dpmac) { > 52 status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(dpmac), 53 "_ADR", NULL, &adr); 54 if (ACPI_FAILURE(status)) { 55 dev_info(dev, "_ADR returned status 0x%x\n", status); 56 continue; 57 } else { 58 id = (u32)adr; 59 if (id == dpmac_id) 60 return dpmac; 61 } 62 } 63 } 64 return NULL; 65 } 66 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
