Add debug prints, test patch for moving i915 to atomic PWM.
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
---
drivers/pwm/pwm-lpss.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c
index 2cb0e2a9c08c..c1f8e6da0cd7 100644
--- a/drivers/pwm/pwm-lpss.c
+++ b/drivers/pwm/pwm-lpss.c
@@ -119,6 +119,8 @@ static void pwm_lpss_prepare(struct pwm_lpss_chip *lpwm, struct pwm_device *pwm,
ctrl |= PWM_ENABLE;
if (orig_ctrl != ctrl) {
+ dev_err(pwm->chip->dev, "prepare 0x%08x -> 0x%08lx\n",
+ orig_ctrl, ctrl | PWM_SW_UPDATE);
pwm_lpss_write(pwm, ctrl);
pwm_lpss_write(pwm, ctrl | PWM_SW_UPDATE);
}
@@ -126,8 +128,15 @@ static void pwm_lpss_prepare(struct pwm_lpss_chip *lpwm, struct pwm_device *pwm,
static inline void pwm_lpss_cond_enable(struct pwm_device *pwm, bool cond)
{
- if (cond)
- pwm_lpss_write(pwm, pwm_lpss_read(pwm) | PWM_ENABLE);
+ if (cond) {
+ u32 orig_ctrl, ctrl;
+
+ orig_ctrl = ctrl = pwm_lpss_read(pwm);
+ ctrl |= PWM_ENABLE;
+ dev_err(pwm->chip->dev, "enable 0x%08x -> 0x%08x\n",
+ orig_ctrl, ctrl);
+ pwm_lpss_write(pwm, ctrl);
+ }
}
static int pwm_lpss_apply(struct pwm_chip *chip, struct pwm_device *pwm,
@@ -200,6 +209,9 @@ static void pwm_lpss_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
state->enabled = !!(ctrl & PWM_ENABLE);
pm_runtime_put(chip->dev);
+
+ dev_err(pwm->chip->dev, "initial state 0x%08x period %d duty_cycle %d enabled %d\n",
+ ctrl, state->period, state->duty_cycle, state->enabled);
}
static const struct pwm_ops pwm_lpss_ops = {
--
2.26.2
