Hi Sakari,
On 20-03-09 15:37, Sakari Ailus wrote:
> Hi Marco,
>
> Thanks for the patch.
>
> On Thu, Mar 05, 2020 at 03:56:01PM +0100, Marco Felsch wrote:
> > If I understood it right the ports should be numbered using the "port"
> > property and not the "reg" property. I stumbled over it during
> > extending the v4l2_fwnode_parse_link() helper which also use the "port"
> > property.
> >
> > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > ---
> > Hi,
> >
> > I don't know if this is right since I'm not a ACPI guy *sorry*
> > Anyway reading the doc description and the v4l2_fwnode_parse_link() code
> > give me a 2/3 chance.
>
> Looking at the documentation, this indeed seems to be a bug in the
> documentation. The code is right, as is the example. As the property was
> previously called "port", there is no actual harm even if someone just read
> the documentation, and not the examples or the code parsing this.
>
> The buggy patch is a4138e7c12287268348cc2dcad414a62c515d77a .
>
> Could you use this instead?
Of course, thanks for the clarification. It seems that we need to update the
v4l2_fwnode_parse_link() too?
Regards,
Marco
> diff --git a/Documentation/firmware-guide/acpi/dsd/graph.rst b/Documentation/firmware-guide/acpi/dsd/graph.rst
> index 1a6ce7afba5ea..2f19a0487b18c 100644
> --- a/Documentation/firmware-guide/acpi/dsd/graph.rst
> +++ b/Documentation/firmware-guide/acpi/dsd/graph.rst
> @@ -56,7 +56,7 @@ package would be::
>
> Package() { "endpoint@0", "EP40" }
>
> -Each port node contains a property extension key "port", the value of which is
> +Each port node contains a property extension key "reg", the value of which is
> the number of the port. Each endpoint is similarly numbered with a property
> extension key "reg", the value of which is the number of the endpoint. Port
> numbers must be unique within a device and endpoint numbers must be unique
>
> --
> Sakari Ailus
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
