On Tue, 2020-03-03 at 20:03 +0100, Rafael J. Wysocki wrote:
>
> What "magic numbers" exactly do you mean? The SRIOV and FLR delays?
> Why not to be more specific here if so?
You are right. I am extending the commit message like this for the next version:
PCI: Clean up and document PM/reset delays
The existing set of PCI_PM_* constants has some inconsistencies (_WAIT
vs _DELAY suffix), and does not cover all the scenarios that the PCIe
specifications mandates waiting periods for.
In preparation for adding infrastructure to override, on a per-device
basis, the individual waiting periods using standardized mechanisms,
this commit introduces and documents constants providing the default
values for various waiting scenarios all around PCI device resets,
PM state changes, and enabling SR-IOV VFs.
Several instances of 'msleep(100)' in the FLR and VF enable codepaths
have been adjusted to use the newly introduced constants instead.
Corresponding explanatory code comments were removed, as they are now
superseded by the documentation of the constants.
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
