Rafael J. Wysocki <rafael@xxxxxxxxxx> 於 2020年3月4日 週三 上午6:23寫道: > > On Tue, Mar 3, 2020 at 10:09 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > > > > On Tue, Mar 3, 2020 at 8:29 AM Jian-Hong Pan <jian-hong@xxxxxxxxxxxx> wrote: > > > > > > Rafael J. Wysocki <rafael@xxxxxxxxxx> 於 2020年3月2日 週一 下午7:45寫道: > > > > > > [cut] > > > > > > > Originally, ec_install_handlers() will return the returned value from > > > install_gpio_irq_event_handler() from acpi_dev_gpio_irq_get(), which > > > is -EPROBE_DEFER, instead of -ENXIO. However, ec_install_handlers() > > > returns -ENXIO directly if install_gpio_irq_event_handler() returns > > > false in patch ("ACPI: EC: Consolidate event handler installation > > > code"). Here needs some modification. > > > > Thanks, I forgot about the -EPROBE_DEFER case. > > The top-most commit in the git branch at > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > acpi-ec-work > > has been updated to take that case into account (I think that it > should be spelled out explicitly or it will be very easy to overlook > in the future). > > Please test this one if possible. Tested the commits on some laptops including ASUS UX434DA. The brightness hotkeys are working now. Jian-Hong Pan