On Mon, Mar 2, 2020 at 6:54 AM Jian-Hong Pan <jian-hong@xxxxxxxxxxxx> wrote: > > Daniel Drake <drake@xxxxxxxxxxxx> 於 2020年2月28日 週五 下午5:43寫道: > > > > On Thu, Feb 27, 2020 at 10:25 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: > > > The purpose of this series of update of the ACPI EC driver is to make its > > > initialization more straightforward. > > > > > > They fix a couple of issues, clean up some things, remove redundant code etc. > > > > > > Please refer to the changelogs of individual patches for details. > > > > > > For easier access, the series is available in the git branch at > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > > > acpi-ec-work > > > > > > on top of 5.6-rc3. > > > > Jian-Hong, can you please test this on Asus UX434DA? > > Check if the screen brightness hotkeys are still working after these changes. > > Hi Rafael, > > Thanks for your patches, but we found an issue: > The laptops like ASUS UX434DA's screen brightness hotkeys work before > this patch series. However, the hotkeys are failed with the patch > "ACPI: EC: Unify handling of event handler installation failures". So I have modified the series to avoid the change that can possibly break this. Can you please pull the new series from git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-ec-work (same branch) and retest? I'll post the updated patches later this week, but it would be good to try them on now if possible. Thanks!