Hi Florian > -----Original Message----- > From: Florian Fainelli <f.fainelli@xxxxxxxxx> > Sent: Monday, February 3, 2020 11:32 PM > To: Calvin Johnson <calvin.johnson@xxxxxxx>; linux.cj@xxxxxxxxx; Jon <snip> > On 1/31/20 7:34 AM, Calvin Johnson wrote: > > From: Calvin Johnson <calvin.johnson@xxxxxxxxxxx> > > > > This patch series provides ACPI support for xgmac_mdio and dpaa2-mac > > driver. Most of the DT APIs are replaced with fwnode APIs to handle > > both DT and ACPI nodes. > > > > Old patch by Marcin Wojtas: (mdio_bus: Introduce fwnode MDIO helpers), > > is reused in this series to get some fwnode mdio helper APIs. > > Andrew's comment on your first patch is a good summary of what this patch > series does, instead of consolidating the existing code and making it less of_* > centric and more firmware agnostic, this duplicates the existing infrastructure > almost line for line to create a fwnode specific implementation. The > preference would be for you to move away from that and use device_* > properties as much as possible while making the code capable of handling all > firmware implementations. Thanks for the suggestion. Will take this direction for v2. > Can you also show a few DSDT for the devices that you are working so we can > a feeling of how you represented the various properties and parent/child > devices dependencies? https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms/tree/Platform/NXP/LX2160aRdbPkg/AcpiTables/Dsdt/Mdio.asl?h=LX2160_UEFI_ACPI_EAR1 https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms/tree/Platform/NXP/LX2160aRdbPkg/AcpiTables/Dsdt/Mc.asl?h=LX2160_UEFI_ACPI_EAR1 Thanks Calvin
