Hi Andrew, > -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: Friday, January 31, 2020 9:58 PM <snip> > On Fri, Jan 31, 2020 at 09:04:34PM +0530, Calvin Johnson wrote: > > From: Marcin Wojtas <mw@xxxxxxxxxxxx> > > > > This patch introduces fwnode helper for registering MDIO bus, as well > > as one for finding the PHY, basing on its firmware node pointer. > > Comparing to existing OF equivalent, > > fwnode_mdiobus_register() does not support: > > * deprecated bindings (device whitelist, nor the PHY ID embedded > > in the compatible string) > > * MDIO bus auto scanning > > > > Signed-off-by: Marcin Wojtas <mw@xxxxxxxxxxxx> > > Signed-off-by: Calvin Johnson <calvin.johnson@xxxxxxxxxxx> > > Hi Calvin > no > This appears to but a cut and paste, follow by an intelligent s/of/fwnode/g. In this patchset, I tried to reuse Marcin's patch which was posted on 2017/12/18. https://lkml.org/lkml/2017/12/18/211 With my patch([v1,2/7] mdio_bus: modify fwnode phy related functions), I've made modifications to this(v1,1/7) patch to adapt to the changes in the kernel. > Did you make any attempt to consolidate the two implementations? It > seems like there should be some level of abstraction that hides away the > difference between DT properties, and DT properties stuffed into ACPI > tables? Yes attempt is to consolidate DT and ACPI into fwnode. Sure, I'll revisit the patch and try to work on your recommendation. Thanks Calvin
