Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output

To: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
From: Hans de Goede <hdegoede@xxxxxxxxxx>
Date: Wed, 1 Jan 2020 15:51:52 +0100
Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Bastien Nocera <hadess@xxxxxxxxxx>, Dmitry Mastykin <mastichi@xxxxxxxxx>, linux-gpio@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx
In-reply-to: <20191230100844.GC2628@lahna.fi.intel.com>
References: <20191225132812.90889-1-hdegoede@redhat.com> <20191227141220.GA2628@lahna.fi.intel.com> <acafef49-bd32-6900-01d2-f6adccabe201@redhat.com> <20191230100844.GC2628@lahna.fi.intel.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1

Hi,

On 30-12-2019 11:08, Mika Westerberg wrote:

On Fri, Dec 27, 2019 at 11:47:38PM +0100, Hans de Goede wrote:

The problem is that we hit this path everytime we output a value on the
pin. I guess we can change the WARN to dev_info_once() if you prefer that.


Yes, I think dev_info_once() would be fine.


Ok, version 3 replacing the WARN() with a dev_info_once coming up.

Regards,

Hans

References:
- [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
  - From: Hans de Goede
- Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
  - From: Mika Westerberg
- Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
  - From: Hans de Goede
- Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
  - From: Mika Westerberg