Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hans de Goede <hdegoede@xxxxxxxxxx>
Subject: Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Date: Mon, 30 Dec 2019 12:08:44 +0200
Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Bastien Nocera <hadess@xxxxxxxxxx>, Dmitry Mastykin <mastichi@xxxxxxxxx>, linux-gpio@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx
In-reply-to: <acafef49-bd32-6900-01d2-f6adccabe201@redhat.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20191225132812.90889-1-hdegoede@redhat.com> <20191227141220.GA2628@lahna.fi.intel.com> <acafef49-bd32-6900-01d2-f6adccabe201@redhat.com>

On Fri, Dec 27, 2019 at 11:47:38PM +0100, Hans de Goede wrote:
> The problem is that we hit this path everytime we output a value on the
> pin. I guess we can change the WARN to dev_info_once() if you prefer that.

Yes, I think dev_info_once() would be fine.

Follow-Ups:
- Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
  - From: Hans de Goede

References:
- [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
  - From: Hans de Goede
- Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
  - From: Mika Westerberg
- Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
  - From: Hans de Goede

Prev by Date: [PATCH V2] ACPI: introduce support for FPDT table
Next by Date: Re: [PATCH] pinctrl: baytrail: Do not clear IRQ flags on direct-irq enabled pins
Previous by thread: Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
Next by thread: Re: [PATCH v2] pinctrl: baytrail: Remove WARN when setting direct-irq pin to output
Index(es):
- Date
- Thread

[Index of Archives] [Linux IBM ACPI] [Linux Power Management] [Linux Kernel] [Linux Laptop] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]