On 2019/12/23 18:35, John Garry wrote: > On 23/12/2019 09:23, Hanjun Guo wrote: >> In IORT spec >> (http://infocenter.arm.com/help/topic/com.arm.doc.den0049d/DEN0049D_IO_Remapping_Table.pdf), >> id_num means Number of IDs minus one, update the comment. >> >> Signed-off-by: Hanjun Guo <guohanjun@xxxxxxxxxx> >> --- >> >> This patch just for comments, needs to be upstream in ACPICA first. >> >> include/acpi/actbl2.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h >> index e45ced2..382642f 100644 >> --- a/include/acpi/actbl2.h >> +++ b/include/acpi/actbl2.h >> @@ -104,7 +104,7 @@ enum acpi_iort_node_type { >> struct acpi_iort_id_mapping { >> u32 input_base; /* Lowest value in input range */ >> - u32 id_count; /* Number of IDs */ >> + u32 id_count; /* Number of IDs in the range minus one */ > > The IORT spec also uses the term "Length" in the examples... More confusing...