On Tue, 3 Sep 2019 11:03:45 +1000 Daniel Black <daniel@xxxxxxxxxxxxx> wrote: > On Mon, 2 Sep 2019 23:28:50 +0200 > "Rafael J. Wysocki" <rafael@xxxxxxxxxx> wrote: > > > On Tue, Aug 6, 2019 at 6:24 AM Daniel Black <daniel@xxxxxxxxxxxxx> wrote: > > > > > > ACPI-6.3 corresponds to when hmat revision was bumped from > > > 1 to 2. In this version ACPI_HMAT_MEMORY_PD_VALID was > > > deprecated and made reserved. > > > > > > As such in revision 2+ we shouldn't be testing this flag. > > > > > > This is as per ACPI-6.3, 5.2.27.3, Table 5-145 > > > "Memory Proximity Domain Attributes Structure" > > > for Flags. > > > > > > Signed-off-by: Daniel Black <daniel@xxxxxxxxxxxxx> > > > > Keith, any comments? > > FYI this was found when I was testing Tao Xu's qemu implementation of HMAT ACPI-6.3 which has no implementation of ACPI_HMAT_MEMORY_PD_VALID. > > Current patch implementing Memory Proximity Domain Attributes Structure: > https://patchwork.kernel.org/patch/11125301/ On Mon, 12 Aug 2019 16:03:15 +0800 Tao Xu <tao3.xu@xxxxxxxxx> wrote: > > Looks good to me. > > Reviewed-by: Tao Xu <tao3.xu@xxxxxxxxx> Ping. Any comments?
