Hi Liguang, On 26/07/2019 10:29, 乱石 wrote: > 在 2019/7/25 20:46, James Morse 写道: >> On 15/07/2019 07:58, luanshi wrote: >>> To avoid memory leaks, destroy ghes_estatus_pool and release memory >>> allocated via vmalloc() on errors in ghes_estatus_pool_init(). >>> >>> Signed-off-by: Liguang Zhang <zhangliguang@xxxxxxxxxxxxxxxxx> >>> --- >> Playing spot-the-difference with [v3], you've moved an empty line. >> >> Please include a change log in this space below the '---' tearoff. This helps reviewers >> know what you changed between versions, and git knows not to add stuff in here to the log. >> >> This is still: >> Reviewed-by: James Morse <james.morse@xxxxxxx> > > Thanks for your review. Because your reviewed-by was given ealier, and the code is > reconstructed, > > so I remove the reviewed-by. I will send v5 by your suggestions. There is no need to post a new version just to pick up the tags. Having a versioned changelog on your future work makes it easier for reviewers to know what changed between versions. Thanks, James
