Re: [PATCH v4] ACPI / APEI: release resources if gen_pool_add fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Liguang,

On 15/07/2019 07:58, luanshi wrote:
> To avoid memory leaks, destroy ghes_estatus_pool and release memory
> allocated via vmalloc() on errors in ghes_estatus_pool_init().
> 
> Signed-off-by: Liguang Zhang <zhangliguang@xxxxxxxxxxxxxxxxx>
> ---

Playing spot-the-difference with [v3], you've moved an empty line.

Please include a change log in this space below the '---' tearoff. This helps reviewers
know what you changed between versions, and git knows not to add stuff in here to the log.

This is still:
Reviewed-by: James Morse <james.morse@xxxxxxx>


Thanks,

James

[v3]
https://lore.kernel.org/linux-acpi/1561258201-26917-1-git-send-email-zhangliguang@xxxxxxxxxxxxxxxxx/


>  drivers/acpi/apei/ghes.c | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 

[...]



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux