On Tue, May 21, 2019 at 04:05:00PM +0100, Charles Keepax wrote: > Bring the ACPI path in sync with the device tree path and handle all the > IRQ fetching at probe time. This leaves the only IRQ handling at device > registration time being that which is passed directly through the board > info as either a resource or an actual IRQ number. > -static int i2c_acpi_get_irq(struct acpi_device *adev, int *irq) > +int i2c_acpi_get_irq(struct i2c_client *client, int *irq) Instead of ping-pong style of the programming, I would rather do this in the same patch, where you introduce a helper (patch 2 I suppose, after my comments against current patch 2 in the series). Also possible to split exporting itself to a separate patch. -- With Best Regards, Andy Shevchenko
