On Tue, May 21, 2019 at 04:04:59PM +0100, Charles Keepax wrote: > Use the available IRQ helper functions, most of the functions have > additional helpful side affects like configuring the trigger type of the > IRQ. More logical to me is to do this as a first patch in the series. Besides that, I would really split it into two: - exporting helper; - using it. -- With Best Regards, Andy Shevchenko