On 21/03/2019 15:52, Sinan Kaya wrote: > On 3/20/2019 1:36 PM, Jean-Philippe Brucker wrote: >> pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ATS); >> + if (!pos) >> + return -ENOSYS; >> + > > You don't need this. pci_enable_ats() validates this via. > > if (!dev->ats_cap) > return -EINVAL; Right, I think I wanted to differentiate lack of ATS capability from actual error in pci_enable_ats(), in which case we'd issue a dev_err(). But the only other errors in pci_enable_ats() are related to invalid STU parameter, which are valid in our case, so the dev_err() is pretty useless. I'll remove this. Thanks, Jean
