On Fri, Nov 02, 2018 at 11:07:34PM +0100, Arnd Bergmann wrote: > On 11/2/18, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: > >> - depends on MFD_AXP20X_I2C && IOSF_MBI > >> + depends on MFD_AXP20X_I2C && IOSF_MBI=y > > > > To me sounds like > > > > select IOSF_MBI would be more appropriate here. > > It looks like we have a mix of the two two, with most drivers > using 'select' and only a few ones using 'depends on'. Mixing > the two often leads to trouble, especially for user-visible > symbols. > > Making it a hidden symbol that is always selected is probably > fine, but then every driver selecting it must also use 'depends > on X86 && PCI'. I doubt every is a correct word here. Whenever driver uses IOSF_MBI it implies X86 and PCI (or should have those dependencies in mind already). But I agree that hide it and select as a library would make more sense than the current state of affairs. -- With Best Regards, Andy Shevchenko
