On Wed, Oct 31, 2018 at 11:08:01AM -0700, Luck, Tony wrote:
> It's not exactly ideal to build the skx_edac.c driver with these
> stubs. Sure, it make the kernel link without errors. But now you
> silently end up with a driver that doesn't really do all you want
> it to do.
>
> Perhaps this isn't a huge issue. Only "randconfig" would try to
> build a kernel without ACPI. The user will find other stuff is
> broken in an ACPI=n kernel long before they notice the lack of
> EDAC error reporting.
Exactly!
> So:
>
> Acked-by: Tony Luck <tony.luck@xxxxxxxxx>
Thx. I'll add it to the lineup for Linus.
> Oops. Return from this isn't "bool". Caller expects 0 = success.
>
> > +static inline int adxl_decode(u64 addr, u64 component_values[]) { return false; }
>
> This should return -EOPNOTSUPP;
Done.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
