On Wed, Oct 31, 2018 at 06:36:32PM +0100, Rafael J. Wysocki wrote: > On Wed, Oct 31, 2018 at 6:09 PM Borislav Petkov <bp@xxxxxxxxx> wrote: > > > > On Wed, Oct 31, 2018 at 05:02:43PM +0000, Luck, Tony wrote: > > > Alternative. Add a > > > > > > select ACPI > > > > > > right before the > > > > > > select ACPI_ADXL > > > > That gives us a whole lotta different troubles: > > > > scripts/kconfig/conf --oldconfig Kconfig > > drivers/acpi/Kconfig:9:error: recursive dependency detected! > > drivers/acpi/Kconfig:9: symbol ACPI is selected by EDAC_SKX > > drivers/edac/Kconfig:232: symbol EDAC_SKX depends on X86_MCE_INTEL > > arch/x86/Kconfig:1129: symbol X86_MCE_INTEL depends on X86_LOCAL_APIC > > arch/x86/Kconfig:1078: symbol X86_LOCAL_APIC depends on X86_UP_APIC > > arch/x86/Kconfig:1053: symbol X86_UP_APIC prompt is visible depending on PCI_MSI > > drivers/pci/Kconfig:8: symbol PCI_MSI is selected by AMD_IOMMU > > drivers/iommu/Kconfig:129: symbol AMD_IOMMU depends on ACPI > > For a resolution refer to Documentation/kbuild/kconfig-language.txt > > subsection "Kconfig recursive dependency limitations" > > > > make[1]: *** [scripts/kconfig/Makefile:69: oldconfig] Error 1 > > make: *** [Makefile:539: oldconfig] Error 2 > > But you could do > > select ACPI_ADXL if ACPI > > I suppose? That make Kconfig happy, but leads to a couple of link errors: MODPOST vmlinux.o drivers/edac/skx_edac.o: In function `skx_mce_check_error': skx_edac.c:(.text+0xab): undefined reference to `adxl_decode' drivers/edac/skx_edac.o: In function `skx_init': skx_edac.c:(.init.text+0x863): undefined reference to `adxl_get_component_names' make: *** [Makefile:1036: vmlinux] Error 1 Perhaps Boris is right and we do need to make ACPI_ADXL user selectable, and have the skylake EDAC driver "depends on ACPI_ADXL" :-( -Tony
