On Tue, Aug 14, 2018 at 09:17:09AM +0200, Hans de Goede wrote:
> Having these helps to verify that the address and names match,
> the DSDT has:
>
> OperationRegion (PMOP, 0x8D, Zero, 0x0100)
> Field (PMOP, DWordAcc, NoLock, Preserve)
> {
> VSYS, 32,
> SYSX, 32,
> SYSU, 32,
> SYSS, 32,
> V50S, 32,
> HOST, 32,
> VBUS, 32,
> HDMI, 32,
> S285, 32,
> X285, 32,
> V33A, 32,
> V33S, 32,
> V33U, 32,
> V33I, 32,
> V18A, 32,
> REFQ, 32,
> V12A, 32,
> V18S, 32,
> V18X, 32,
> ....
> }
>
> And address really is just an offset into this "struct", so
> basically to check all the addresses are correct, I first check
> that all the labels which I've put in comments (including the
> ones which do not have implemented) match with the list
> of fields in the DSDT and then as a second step I check the
> addresses are 0x00 0x04 0x08 0x0c 0x10 0x14 ...
>
> Having holes in the table makes this a lot harder, note
> there are no holes in the DSDT definition of the struct.
Fair enough :)
Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
