On Sun, Aug 12, 2018 at 06:33:44PM +0200, Hans de Goede wrote: > +/* { > + .address = 0x00, > + .reg = ??, > + .bit = ??, > + }, ** VSYS */ Do you really need to keep these here? I think it just makes the table uglier than it needs to be. And the code you took the entries does not have them either.