On Thu, May 17, 2018 at 6:47 PM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > Is below patch does what you were looking for ? Somewhat. See below for some minors. > of_property_read_u64 searches for a property in a device node and read > a 64-bit value from it. Instead of using of_get_property to get the > property and then read 64-bit value using of_read_number, we can make > use of of_property_read_u64. Suggested-by? > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx> > - cache_size = of_get_property(np, propname, NULL); > - if (cache_size) > - this_leaf->size = of_read_number(cache_size, 1); > + if (!of_property_read_u64(np, propname, &cache_size)) > + this_leaf->size = cache_size; I suppose it's something like this ret = of_property_...(..., &this_leaf->VAR); if (ret) warning / set default / etc > propname = cache_type_info[ct_idx].line_size_props[i]; > - line_size = of_get_property(np, propname, NULL); > - if (line_size) > + line_size = of_property_read_u64(np, propname, &line_size); > + if (line_size) { ret = ... if (ret) { > + this_leaf->coherency_line_size = line_size; > break; > + } > + if (!of_property_read_u64(np, propname, &nr_sets)) > + this_leaf->number_of_sets = nr_sets; As in first case. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html