On 04/19/2018 10:35 AM, James Morse wrote: > Hi Alex, > > (I haven't read through all this yet, just on this one:) > > On 04/19/2018 03:57 PM, Alex G. wrote: >> Maybe it's better move the AER handling to NMI/IRQ context, since >> ghes_handle_aer() is only scheduling the real AER andler, and is irq >> safe. I'm scratching my head about why we're messing with IRQ work from >> NMI context, instead of just scheduling a regular handler to take care >> of things. > > We can't touch schedule_work_on() from NMI context as it takes spinlocks > and > disables interrupts. (see __queue_work()) The NMI may have interrupted > IRQ-context code > that was already holding the same locks. > > IRQ-work behaves differently, it uses an llist for the work and an arch > code hook > to raise a self-IPI. That makes sense. Thank you! Alex > > Thanks, > > James -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
