On Tue, Apr 3, 2018 at 8:29 AM, Dave Jiang <dave.jiang@xxxxxxxxx> wrote: > [..] >> + if (test_and_set_bit(ARS_REQ, &nfit_spa->ars_state)) >> + busy++; >> + else { >> + if (flags == ND_ARS_RETURN_PREV_DATA) > > > if (flags & ND_ARS_RETURN_PREV_DATA)? > > I think the spec allows other bits set in the flag byte. > True, and it might be better to pass in the kernel's ARS_SHORT flag rather than the firmware interface value. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html