> On 31 Jan 2018, at 2:17 AM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Jan 30, 2018 at 8:07 AM, Kai-Heng Feng
> <kai.heng.feng@xxxxxxxxxxxxx> wrote:
>> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out
>> of box.
>>
>> The touchpad relies on its _INI method to update its _HID value from
>> XXXX0000 to SYNA2393.
>> Also, the _STA relies on value of I2CN to report correct status.
>>
>> Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be
>> correctly set up, and _INI can get run. The ACPI table in this machine
>> is designed to get parsed this way.
>>
>> Also, change the quirk table to a more generic name.
>
>> +static int set_gbl_term_list(const struct dmi_system_id *id)
>> +{
>> + pr_notice("%s detected - parse the entire table as a term_list\n",
>> + id->ident);
>> + acpi_gbl_parse_table_as_term_list = 1;
>> + return 0;
>> +}
>> #endif
>
> The above should be outside of another #ifdef. Basically after the above #endif.
Right, I overlooked that. Thanks.
>
>> #else
>
>> #endif
>
>> @@ -1005,7 +1034,7 @@ void __init acpi_early_init(void)
>
>> * If the machine falls into the DMI check table,
>> * DSDT will be copied to memory
>> */
>
> It might make sense to adjust comment above that it's about quirks in
> general. And, if needed, move current content to actual DMI group of
> records.
Thanks for the suggestions.
I’ll address them in patch v3.
Kai-Heng
>
>> - dmi_check_system(dsdt_dmi_table);
>> + dmi_check_system(acpi_quirks_dmi_table);
>
> --
> With Best Regards,
> Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
