> -----Original Message----- > From: Mario.Limonciello@xxxxxxxx [mailto:Mario.Limonciello@xxxxxxxx] > Sent: Tuesday, January 30, 2018 11:03 AM > To: Schmauss, Erik <erik.schmauss@xxxxxxxxx>; andy.shevchenko@xxxxxxxxx; > kai.heng.feng@xxxxxxxxxxxxx > Cc: rjw@xxxxxxxxxxxxx; lenb@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; Moore, Robert <robert.moore@xxxxxxxxx> > Subject: RE: [PATCH] ACPI: Parse entire table as a term_list for Dell > XPS 9570 and Precision M5530 > > > > > -----Original Message----- > > From: Schmauss, Erik [mailto:erik.schmauss@xxxxxxxxx] > > Sent: Tuesday, January 30, 2018 12:38 PM > > To: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>; Kai-Heng Feng > > <kai.heng.feng@xxxxxxxxxxxxx> > > Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>; Len Brown > > <lenb@xxxxxxxxxx>; ACPI Devel Maling List > > <linux-acpi@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux- > > kernel@xxxxxxxxxxxxxxx>; Limonciello, Mario > > <Mario_Limonciello@xxxxxxxx>; Moore, Robert <robert.moore@xxxxxxxxx> > > Subject: RE: [PATCH] ACPI: Parse entire table as a term_list for Dell > > XPS 9570 and Precision M5530 > > > > Hi, > > > -----Original Message----- > > > From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi- > > > owner@xxxxxxxxxxxxxxx] On Behalf Of Andy Shevchenko > > > Sent: Tuesday, January 30, 2018 10:18 AM > > > To: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> > > > Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>; Len Brown > > > <lenb@xxxxxxxxxx>; ACPI Devel Maling List > > > <linux-acpi@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux- > > > kernel@xxxxxxxxxxxxxxx>; Mario Limonciello > > > <mario.limonciello@xxxxxxxx> > > > Subject: Re: [PATCH] ACPI: Parse entire table as a term_list for > > > Dell XPS 9570 and Precision M5530 > > > > > > On Tue, Jan 30, 2018 at 8:07 AM, Kai-Heng Feng > > > <kai.heng.feng@xxxxxxxxxxxxx> wrote: > > > > The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work > > > > out of box. > > > > > > > > The touchpad relies on its _INI method to update its _HID value > > > > from > > > > XXXX0000 to SYNA2393. > > > > Also, the _STA relies on value of I2CN to report correct status. > > > > > > > > Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be > > > > correctly set up, and _INI can get run. The ACPI table in this > > > > machine is designed to get parsed this way. > > > > I thought I would give everyone an update: we are getting close to > > finishing patches to enable this term list parsing by default as well > > as a few other fixes with forward referencing of package elements. > > Once we have established that these patches are stable, we will get > > rid of acpi_gbl_parse_table_as_term_list. So this quirk may not be > needed in the near future... > > Rafael, > > Would you be opposed to carrying a patch similar to this (proposed) > quirk patch in kernel and reverting when Erik submits patches that get > rid of acpi_gbl_parse_table_as_term_list? > > The reason being, I think this could also be a candidate to bring back > to @stable and fix this problem on earlier kernels too. > > I don’t believe the patches that get rid of > acpi_gbl_parse_table_as_term_list likely will be good candidates for > @stable. > Does anyone remember what was the exact problem that forced the creation of parse_table_as_term_list in the first place? Bob > > > > > Erik > > > > > > > > Also, change the quirk table to a more generic name. > > > > > > > +static int set_gbl_term_list(const struct dmi_system_id *id) { > > > > + pr_notice("%s detected - parse the entire table as a > term_list\n", > > > > + id->ident); > > > > + acpi_gbl_parse_table_as_term_list = 1; > > > > + return 0; > > > > +} > > > > #endif > > > > > > The above should be outside of another #ifdef. Basically after the > above #endif. > > > > > > > #else > > > > > > > #endif > > > > > > > @@ -1005,7 +1034,7 @@ void __init acpi_early_init(void) > > > > > > > * If the machine falls into the DMI check table, > > > > * DSDT will be copied to memory > > > > */ > > > > > > It might make sense to adjust comment above that it's about quirks > in general. > > > And, if needed, move current content to actual DMI group of records. > > > > > > > - dmi_check_system(dsdt_dmi_table); > > > > + dmi_check_system(acpi_quirks_dmi_table); > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko > > > -- > > > To unsubscribe from this list: send the line "unsubscribe > > > linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx > > > More majordomo info at http://vger.kernel.org/majordomo-info.html ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
