On Wed, Dec 13, 2017 at 09:53:21AM +0100, Hans de Goede wrote: > On 13-12-17 01:00, Rafael J. Wysocki wrote: > > On Monday, September 25, 2017 9:21:09 PM CET Johannes Stezenbach wrote: > > > SATA controller is enabled on Asus E200HA even though the > > > machine doesn't use it (it has eMMC storage), however > > > SATA being on blocks S0ix entry so we need to disable it. > > > > > > Signed-off-by: Johannes Stezenbach <js@xxxxxxxxx> > > > > Mika, Andy, Hans, any comments on this one? > > Seems sensible to me, I'm afraid we may need the same quirk on > other devices, but I see no way around this. > > Although, maybe we need to have a specialized (derived) > ahci driver for these Atom SoCs and in there if no > disk is detected do this through the clock framework? > > That may be better then a long list of quirks. > > Johannes, question how did you test this and figure out > which clocks to disable, a quick howto on this, I think > a patch adding a little howto / README as say > Documentation/power/intel-S0ix-debugging.txt > documenting this would be great. I'm certainly interested > in trying to reproduce this on some of my own Bay Trail and > Cherry Trail devices and add fixes for those if necessary. I put my E200HA aside due to lack of time, so it's unlikely I'll send documentation patches anytime soon. Basically everything is documented in bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=193891 For the SATA issue I just poked wildly around in registers using busybox devmem, after applying S0ix blocker debug patch I tried to disable some devices which were printed: https://bugzilla.kernel.org/show_bug.cgi?id=193891#c53 (Obviously bug 193891 is misnamed, most of what's discussed there doesn't directly relate to PMIC. Sorry for creating a mess, but my understanding of the platform was very low when I created it.) The thing is that the public CHT datasheet (atom-z8000-datasheet-vol-1.pdf + vol-2) doesn't even mention SATA, and there is no PCI device for it. OTOH, baytrail datasheet (atom-e3800-family-datasheet.pdf) specifies SATA and BIT_SATA was already defined in pmc_atom.h. Besides SATA, I also needed to disable dw DMA, using a hack patch or devmem, but eventually it might be solved properly: https://bugzilla.kernel.org/show_bug.cgi?id=196861 Thanks, Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
