On Wed, Dec 13, 2017 at 09:56:45AM +0100, Hans de Goede wrote: > On 13-12-17 01:01, Rafael J. Wysocki wrote: > > On Monday, September 25, 2017 9:23:52 PM CET Johannes Stezenbach wrote: > > > d31fd43c0f9a "clk: x86: Do not gate clocks enabled by the firmware" > > > exposed an issue on Asus E200HA where BIOS enables unused > > > Atom PMC clocks which prevent the system from entering S0ix. > > > Add a quirk to disable these clocks on E200HA. > > > > > > Signed-off-by: Johannes Stezenbach <js@xxxxxxxxx> > > > > Mika, Andy, Hans, any comments here? > > This seems like it is papering over an issue in the > d31fd43c0f9a "clk: x86: Do not gate clocks enabled by the firmware" > patch to me. That patch seems like a somewhat hackish fix to > me, it would be better to figure out which device needs the clock > in question and fix the device's driver... > > And or maybe have a mask of clocks for which to do this check > and not do it for all clocks at least? That way we can maybe > fix both Johannes and Carlo's issue in one go without needing > device specific quirks ? > > Carlo, do you remember which clock you needed this for ? > > Johannes, same question for you, which clock is being kept > alive because of this ? IIRC all of these platform clocks need to be disabled for S0ix, but d31fd43c0f9a keeps them all enabled (if BIOS had enabled them), and only the one claimed by the audio codec driver is disabled by it before trying to enter S0ix. Yes, my vote would be to revert d31fd43c0f9a and fix the issue properly, but my patch was the result of previous discussion. Since it's BIOS' fault to have these clocks enabled I think a platform quirk isn't too bad. Thanks, Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
