On Tue, Dec 05, 2017 at 02:24:29PM -0800, Luck, Tony wrote:
> So this is what that would look like (on top of existing patches,
> but would be folded into them for next version):
>
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 5c0c4a358f67..7f0bc4cd5086 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -233,10 +233,11 @@ config EDAC_SKX
> tristate "Intel Skylake server Integrated MC"
> depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
> select DMI
> - select ACPI_NFIT
> help
> Support for error detection and correction the Intel
> - Skylake server Integrated Memory Controllers.
> + Skylake server Integrated Memory Controllers. If your
> + has non-volatile DIMMs you should also manually select
> + CONFIG_ACPI_NFIT
>
> config EDAC_PND2
> tristate "Intel Pondicherry2"
> diff --git a/drivers/edac/skx_edac.c b/drivers/edac/skx_edac.c
> index f42e382f82b1..8374deb83246 100644
> --- a/drivers/edac/skx_edac.c
> +++ b/drivers/edac/skx_edac.c
> @@ -387,12 +387,16 @@ static int get_nvdimm_info(struct dimm_info *dimm, struct skx_imc *imc,
> int smbios_handle;
> u32 dev_handle;
> u16 flags;
> - u64 size;
> + u64 size = 0;
>
> dev_handle = ACPI_NFIT_BUILD_DEVICE_HANDLE(dimmno, chan, imc->lmc,
> imc->src_id, 0);
>
> smbios_handle = nfit_get_smbios_id(dev_handle, &flags);
> + if (smbios_handle == -EOPNOTSUPP) {
> + pr_warn_once("skx_edac: can't find size of NVDIMM\n");
" ... find size of NVDIMM. Try enabling CONFIG_ACPI_NFIT.\n"
to make it a bit more user-friendly.
Looks ok, otherwise.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
