On Tue, Dec 05, 2017 at 11:54:51AM +0100, Borislav Petkov wrote:
> On Thu, Nov 30, 2017 at 12:40:42PM -0800, Tony Luck wrote:
> > config EDAC_SKX
> > tristate "Intel Skylake server Integrated MC"
> > depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
> > + select DMI
> > + select ACPI_NFIT
>
> Hmm, that ACPI_NFIT depends on a bunch of stuff and enabling EDAC_SKX
> would pull in all that. Should we make this a user choice instead?
>
> I mean, there could be boxes which don't have nvdimms so all that code
> would be dead weight there...
I could. But what happens when someone ends up on a system with
an edac driver configured without ACPI_NFIT that does have NVDIMMs?
I can make a stub version of nfit_get_smbios_id() that returns some
error code ... and have the EDAC driver report size==0.
Would that be OK?
> <---- newline here.
>
> > + size = dmi_memdev_size(smbios_handle);
> > + if (size == ~0ul) {
> > + skx_printk(KERN_ERR, "Can't find size for NVDIMM ADR=%x/SMBIOS=%x\n",
> > + dev_handle, smbios_handle);
> > + return 0;
> > + }
>
> Ditto.
>
> > + edac_dbg(0, "mc#%d: channel %d, dimm %d, %lld Mb (%lld pages)\n",
> > + imc->mc, chan, dimmno, size >> 20, size >> PAGE_SHIFT);
> > +
> > + dimm->nr_pages = size >> PAGE_SHIFT;
> > + dimm->grain = 32;
> > + dimm->dtype = DEV_UNKNOWN;
> > + dimm->mtype = MEM_NVDIMM;
> > + dimm->edac_mode = EDAC_SECDED; /* likely better than this */
>
> Ditto.
>
> /me hands aegl a bunch of newlines - seems he's all out of \n's
/me finds that the "Enter" key on his keyboard will put in a newline.
Hurrah! now I don't have to copy/paste them from Boris.
-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
