Hi,
On 22-11-17 01:41, Rafael J. Wysocki wrote:
On Thursday, November 16, 2017 10:33:04 AM CET Hans de Goede wrote:
Hi,
On 15-11-17 18:16, Rafael J. Wysocki wrote:
On Wed, Nov 15, 2017 at 3:07 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
I've been debugging some spurious suspend issues on various devices,
at least on some devices these spurious suspends are caused by surious
LID closed events being send to userspace.
Running e.g. evemu-record after noticing a spurious suspend is too late
to detect that a LID closed event it the (probable) cause of this.
This commit adds a pr_info("ACPI LID closed\n") call to help debugging.
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
---
drivers/acpi/button.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index ef1856b15488..07da60fe9cae 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -210,6 +210,9 @@ static int acpi_lid_notify_state(struct acpi_device *device, int state)
}
/* Send the platform triggered reliable event */
if (do_update) {
+ if (!state)
+ pr_info("ACPI LID closed\n");
Why pr_info()?
The purpose of the patch is to help debug spurious suspends seen on
some devices (typically Intel based tablets or 2in1s) so the goal is to
look at the logs after the fact and figure things out, so we want something
which shows up by default (typically a lid close leads to a suspend which
already causes some logging anyways), but this is not an error or a warning,
so I ended up with pr_info.
This prints a useless message avery time the lid closes on *many* systems that
don't have this problem which is a bit overly excessive IMO.
And you can always ask bug reporters to collect logs with dynamic debug enabled
if need be, can't you?
Ok, I will send a v2 using pr_debug instead.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
