Re: [PATCH 1/2] ACPI: button: Add an info message when we're sending a LID closed event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 15, 2017 at 3:07 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> I've been debugging some spurious suspend issues on various devices,
> at least on some devices these spurious suspends are caused by surious
> LID closed events being send to userspace.
>
> Running e.g. evemu-record after noticing a spurious suspend is too late
> to detect that a LID closed event it the (probable) cause of this.
> This commit adds a pr_info("ACPI LID closed\n") call to help debugging.
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/acpi/button.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
> index ef1856b15488..07da60fe9cae 100644
> --- a/drivers/acpi/button.c
> +++ b/drivers/acpi/button.c
> @@ -210,6 +210,9 @@ static int acpi_lid_notify_state(struct acpi_device *device, int state)
>         }
>         /* Send the platform triggered reliable event */
>         if (do_update) {
> +               if (!state)
> +                       pr_info("ACPI LID closed\n");

Why pr_info()?

> +
>                 input_report_switch(button->input, SW_LID, !state);
>                 input_sync(button->input);
>                 button->last_state = !!state;
> --
> 2.14.3
>
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux