On Tue, Oct 31, 2017 at 8:38 AM, James Morse <james.morse@xxxxxxx> wrote:
> 7 files changed, 30 insertions(+), 85 deletions(-)
Lovely.
I obviously can't test it, but it looks fine. I *would* suggest just
making the "add fixmap entries" commits with the code that actually
uses them. There's no real reason to have two commits that just add
two entries that aren't used yet.
If it was some meaningful helper function where a split of the commits
makes each commit easier to read, that would be one thing. As it is,
the split just makes it harder to look at the history of the code (ie
"I wonder where this was introduced - let's use 'git blame'. Oh,
that's not useful").
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
