On 2017/10/22 17:38, Rafael J. Wysocki wrote: > On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng <gengdongjiu@xxxxxxxxxx> wrote: >> For the SEA notification, the two functions ghes_sea_add() and >> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA >> is defined. If not, it will return errors in the ghes_probe() >> and not continue. If the probe is failed, the ghes_sea_remove() >> also has no chance to be called. Hence, remove the unnecessary >> handling when CONFIG_ACPI_APEI_SEA is not defined. >> >> For the NMI notification, it has the same issue as SEA notification, >> so also remove the unused dead-code for it. >> >> Cc: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx> >> Cc: James Morse <james.morse@xxxxxxx> >> Signed-off-by: Dongjiu Geng <gengdongjiu@xxxxxxxxxx> >> Tested-by: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx> >> Reviewed-by: Borislav Petkov <bp@xxxxxxx> > I applied one of the previous iterations. > > Do I need to replace it with this version? Rafael, I checked your applying, your applying is right. so no need to replace. https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=3275fe60d1138e0cb57be9a3f46306b4d031c643 which is already "Reviewed-by: Borislav Petkov <bp@xxxxxxx>" Thanks > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html