"Luck, Tony" <tony.luck@xxxxxxxxx> writes: >> One thing I missed commenting on in the previous version - >> >> Have you thought of exposing the error records via /sys/firmware/acpi? >> The tables are already exposed there and as BERT is part of ACPI >> logically that's a better fit compared to a misc device. > > That was my first thought :-) > > But I got stuck on how to name things. The BERT entry appears in > /sys/firmware/acpi/tables/ ... but the code doesn't know anything special > about "BERT", it just iterates over all the tables and makes them all > appear. > > I thought about making it /sys/firmware/acpi/tables/BERT.data, but that > seemed very ugly (this file isn't a "table", so why does it appear in the > "tables" directory? So maybe /sys/firmware/acpi/table-data/BERT? Now > the driver has to make another directory. > > Thoughts? I agree that keeping the error record out of the tables directory makes sense as it's not an ACPI table. The best I could come up with was bert-data or bert-region in /sys/firmware/acpi/apei/. Though, I am OK with "table-data/BERT" as well. > > -Tony > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
