On Wed, Aug 16, 2017 at 04:14:50PM +0800, Dongjiu Geng wrote:
> The revision 0x300 generic error data entry is different
> from the old version, but currently iterating through the
> GHES estatus blocks does not take into account this difference.
> This will lead to failure to get the right data entry if GHES
> has revision 0x300 error data entry.
>
> Update the GHES estatus iteration to properly increment using
iteration macro
> acpi_hest_get_next, and correct the iteration termination condition
Please end function names with parentheses.
> because the status block data length only includes error data length.
<---- newline here.
> Clear the CPER estatus printing iteration logic to use same macro.
s/Clear ... /Convert ... to the same macro./
>
> Signed-off-by: Dongjiu Geng <gengdongjiu@xxxxxxxxxx>
> CC: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx>
> ---
> drivers/acpi/apei/apei-internal.h | 5 -----
> drivers/firmware/efi/cper.c | 12 ++----------
> include/acpi/ghes.h | 5 +++++
> 3 files changed, 7 insertions(+), 15 deletions(-)
With those addressed you can add:
Reviewed-by: Borislav Petkov <bp@xxxxxxx>
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
