On Tue, Jun 27, 2017 at 5:08 PM, Moore, Robert <robert.moore@xxxxxxxxx> wrote: > > >> -----Original Message----- >> From: Lukas Wunner [mailto:lukas@xxxxxxxxx] >> Sent: Tuesday, June 27, 2017 2:24 AM >> To: Zheng, Lv <lv.zheng@xxxxxxxxx> >> Cc: Rafael J. Wysocki <rafael@xxxxxxxxxx>; Moore, Robert >> <robert.moore@xxxxxxxxx>; Wysocki, Rafael J >> <rafael.j.wysocki@xxxxxxxxx>; Ronald Tschalaer <ronald@xxxxxxxxxxxxx>; >> ACPI Devel Maling List <linux-acpi@xxxxxxxxxxxxxxx> >> Subject: Re: ACPICA regression for empty ResourceTemplates >> >> On Tue, Jun 27, 2017 at 01:19:31AM +0000, Zheng, Lv wrote: >> > > On Mon, Jun 26, 2017 at 01:49:03PM +0200, Rafael J. Wysocki wrote: >> > > > On Mon, Jun 26, 2017 at 10:38 AM, Lukas Wunner <lukas@xxxxxxxxx> >> wrote: >> > > > > Hi Robert, >> > > > > >> > > > > ACPICA commit c8eac101 (= Linux commit a83019eb9f1f, "ACPICA: >> > > > > Update resource descriptor handling") is causing a regression >> > > > > when parsing an empty ResourceTemplate: >> > >> > Can it be fixed by using this logic: >> > if (AmlLength < sizeof (AML_RESOURCE_END_TAG) && AmlLength) Instead of >> > the logic introduced in commit a83019eb9f1f? >> > if (AmlLength < sizeof (AML_RESOURCE_END_TAG)) >> >> Unfortunately not, AmlLength is not 0 but 2 in this case (= >> sizeof(struct aml_resource_end_tag)). >> >> >> > If so, could you please offer a fix for upstream? > [Moore, Robert] > > Is the problem seen with something like this? > > Name (BUF1, ResourceTemplate () > { > }) > > When BUF1 is evaluated, the exception happens? > > I think we have all of the ResourceTemplate issues resolved for the next release of ACPICA. OK So I will drop this commit for now and I will add it again along with the next release material to avoid triggering regressions in the meantime. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
