On Tue, Jun 27, 2017 at 01:19:31AM +0000, Zheng, Lv wrote: > > On Mon, Jun 26, 2017 at 01:49:03PM +0200, Rafael J. Wysocki wrote: > > > On Mon, Jun 26, 2017 at 10:38 AM, Lukas Wunner <lukas@xxxxxxxxx> wrote: > > > > Hi Robert, > > > > > > > > ACPICA commit c8eac101 (= Linux commit a83019eb9f1f, "ACPICA: Update > > > > resource descriptor handling") is causing a regression when parsing > > > > an empty ResourceTemplate: > > Can it be fixed by using this logic: > if (AmlLength < sizeof (AML_RESOURCE_END_TAG) && AmlLength) > Instead of the logic introduced in commit a83019eb9f1f? > if (AmlLength < sizeof (AML_RESOURCE_END_TAG)) Unfortunately not, AmlLength is not 0 but 2 in this case (= sizeof(struct aml_resource_end_tag)). > If so, could you please offer a fix for upstream? I'd suggest just reverting the commit, a buffer containing a lone end tag seems to be legal according to the spec, so returning an error seems wrong. Thanks, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
