On Thursday, April 27, 2017 12:35:46 PM Andy Shevchenko wrote: > On Thu, 2017-04-27 at 00:01 +0200, Rafael J. Wysocki wrote: > > On Friday, April 21, 2017 01:48:09 PM Hans de Goede wrote: > > > Some Bay Trail devices use a GPI1 regulator field (address 0x4c) in > > > their 0x8d power OpRegion, add support for this. > > > > > > This fixes AE_BAD_PARAMETER errors getting thrown on these devices > > > and > > > fixes these errors causing these devices to not suspend. > > > > > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > > > Srinivas, Andy, any concerns here? > > Nothing major. > > It might be useful to introduce > > GPI1_LDO_MASK GENMASK(2,0) > GPI1_LDO_ON (3 << 0) > GPI1_LDO_OFF (4 << 0) > > But it's up to you. I'm fine with either. This is a good point IMO. Hans, care to use symbols as suggested by Andy? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
