On Thu, 2017-04-27 at 00:01 +0200, Rafael J. Wysocki wrote:
> On Friday, April 21, 2017 01:48:09 PM Hans de Goede wrote:
> > Some Bay Trail devices use a GPI1 regulator field (address 0x4c) in
> > their 0x8d power OpRegion, add support for this.
> >
> > This fixes AE_BAD_PARAMETER errors getting thrown on these devices
> > and
> > fixes these errors causing these devices to not suspend.
> >
> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Srinivas, Andy, any concerns here?
Nothing major.
It might be useful to introduce
GPI1_LDO_MASK GENMASK(2,0)
GPI1_LDO_ON (3 << 0)
GPI1_LDO_OFF (4 << 0)
But it's up to you. I'm fine with either.
> > ---
> > Changes in v2:
> > -Simplify reg == 0x92 handling (suggested by Andy Shevchenko)
> > -Add special handling for reg == 0x92 to
> > intel_xpower_pmic_get_power() too
> > ---
> > drivers/acpi/pmic/intel_pmic_xpower.c | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/pmic/intel_pmic_xpower.c
> > b/drivers/acpi/pmic/intel_pmic_xpower.c
> > index 1a76c78..c9be430 100644
> > --- a/drivers/acpi/pmic/intel_pmic_xpower.c
> > +++ b/drivers/acpi/pmic/intel_pmic_xpower.c
> > @@ -118,6 +118,10 @@ static struct pmic_table power_table[] = {
> > .reg = 0x10,
> > .bit = 0x00
> > }, /* BUC6 */
> > + {
> > + .address = 0x4c,
> > + .reg = 0x92,
> > + }, /* GPI1 */
> > };
> >
> > /* TMP0 - TMP5 are the same, all from GPADC */
> > @@ -156,7 +160,12 @@ static int intel_xpower_pmic_get_power(struct
> > regmap *regmap, int reg,
> > if (regmap_read(regmap, reg, &data))
> > return -EIO;
> >
> > - *value = (data & BIT(bit)) ? 1 : 0;
> > + /* GPIO1 LDO regulator needs special handling */
> > + if (reg == 0x92)
> > + *value = ((data & 0x07) == 0x03);
> > + else
> > + *value = (data & BIT(bit)) ? 1 : 0;
> > +
> > return 0;
> > }
> >
> > @@ -165,6 +174,10 @@ static int
> > intel_xpower_pmic_update_power(struct regmap *regmap, int reg,
> > {
> > int data;
> >
> > + /* GPIO1 LDO regulator needs special handling */
> > + if (reg == 0x92)
> > + return regmap_update_bits(regmap, reg, 0x07, on ?
> > 0x03 : 0x04);
> > +
> > if (regmap_read(regmap, reg, &data))
> > return -EIO;
> >
> >
>
>
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
